Repository navigation
fix(settings): external agents switch and aligned config gear - #1789
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external agents row in Settings was a plain row with a config gear and no persistent state. This gives it a real switch wired the same way as the other server-side integration toggles: a new
externalAgentskey behindGET/PUT /api/settings/integrations(default on, absent means enabled, partial-safe PUT still works), read throughuseIntegrationsso the row flips like the rest.Two small text changes along the way: the row caption is now the short "Add supported non-OpenWrt devices" line, and the rtlplayground note with the two flashing guide links moved inside the configure dialog, right above the integrations manager where it is actually useful.
refs #1782, refs #1784.