Repository navigation
fix(landing): mobile hero without install CTA and GitHub entry in header - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #224.
Problem
On phones the hero still led with the "Instalar" button, which points to a GNOME package section a mobile visitor cannot use. At the same time the compact header from #224 had no link to the repository, since the desktop anchors and install CTA are hidden below 860 px.
Changes
landing/index.html: the hero install CTA gets ahero-installclass and a GitHub icon link is added to the header actions, pointing to the repository with an accessible label.landing/styles.css: the GitHub icon only shows atmax-width: 860px, the hero install CTA is hidden there, and the desktop layout is untouched.landing/i18n.js:misc.githublabel in ES and EN. Cache-bust bumped to?v=4.Verification
Playwright suite at 360, 390, 414, 1280 and 1440 px: 55/55 checks passing locally and 55/55 against production.
Already deployed to https://nextsync.cloudless.club/ and verified there.
Closes #227