Repository navigation
fix(ui): correct the file counts, the run bar and the folder subtitle - #252
Merged
Merged
Conversation
Singular form when a count is one, in the progress caption, the delete review subtitles and the "files disappeared" sentence (closes #247). The run bar is inset from the card corners and separated from the row border, which used to disappear under it while a run was in flight (closes #248). The folder subtitle describes the remote path as a local copy instead of "Synced in local <folder>", which reads badly and collided with the separator the subtitle parts already use (closes #251).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three defects found while capturing the demo screenshots, all visible in the
folder row of the main window.
Changes
Counted strings (#247).
plural()insrc/util/i18n.rspicks the singularor the plural translation, since the catalog is a flat map without plural
rules. Applied to the progress caption, the two delete review subtitles and the
"files disappeared" sentence. Five entries added to
po/es.poand the catalogregenerated with
tools/gen-translations.py.Run bar (#248). The 3 px bar keeps its height but is inset 12 px from the
card corners, with 2 px above it, so the row border and the separator between
rows stay visible while a run is in flight.
Folder subtitle (#251). "Synced in local {folder}" becomes "Local copy of
{folder}". The subtitle joins its parts with " · ", so the segment does not
carry that separator itself, otherwise the result reads
"Local copy of · Documentos · 5 min ago".
Verification
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testclean: 738 passed, 0 failed, including a new test that covers acount of 1 and 2 in both languages.
1440x960: the subtitles read "Copia local de Documentos / Fotos / Videos",
and during a real sync the bar sits inside the card with the separator still
visible below it.
Closes #247
Closes #248
Closes #251