Repository navigation
refactor(config): drop the unused color_scheme setting - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme switch was removed in v0.70.0 (issue #53), so nothing reads
general.color_scheme: it was parsed, validated and written back, with noeffect on the UI.
Change
GeneralConfig.a config carrying
"color_scheme": "banana"still loads, and the key isgone the next time the config is written. No
schema_versionbump isneeded, the crate never sets
deny_unknown_fields.Verification
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testclean, 739 tests passing.Closes #246