Repository navigation
fix(ui): split the sync preferences and widen the activity list - #254
Merged
Merged
Conversation
The Synchronization page did not fit in a 1440x960 window: its content measured about 1032 px and the delete protection card was cut by the page switcher. The everyday switches (local and remote changes) stay on that page and the exclusions, reliability, detailed output and delete guard move to a new Advanced synchronization page (closes #249). The activity list was clamped to 760 px, which wasted 600 px on a wide window and still truncated long local paths. The cap is now 1100 px, so the rows use most of the window and the centred background of #118 stays (closes #250).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Synchronization page did not fit in a 1440x960 window. Its content
measured about 1032 px, so the delete protection card was cut in half by the
page switcher and, in Spanish, the switch subtitle lost its second line.
The page is split in two. Synchronization keeps the everyday switches
(local and remote changes) and Advanced synchronization takes the
excluded files, reliability, detailed output and the deletion guard. Neither
page has to be scrolled at 1440x960, and both still work at 900x660, where
the five tabs keep their full labels.
The activity list was clamped to 760 px, which left about 340 px of empty
space on each side of a 1440 wide window while still truncating long local
paths. The cap is now 1100 px, so the rows use most of the window; the
centred background that motivated the clamp in #118 is unchanged.
Verification
cargo fmt --checkclean andcargo clippy --all-targets -- -D warningswith no warnings.
cargo test: 738 passed, 0 failed, 1 ignored.mainreports the samenumber, so no test was lost in the split.
the advanced page ends at ~660 px with the delete protection card fully
visible, and the activity list is ~1060 px wide instead of 760.
Closes #249
Closes #250