Repository navigation
fix(editor): align bullets with list text - #170
Merged
Merged
Conversation
Center bullet ornaments on the first visible glyph instead of the shrunk Markdown marker. Remove the residual marker width so wrapped lines keep the same text offset. Refs #169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Bullet placement used the geometry of the shrunken Markdown marker instead of the visible text. The non-zero marker scale could also leave one residual layout pixel, shifting the first line relative to its wrapped continuation.
Verification
make check: 1514 passed, 0 failed, 38 ignored.bullet_alignment,marks_reveal,table_geometry, andheading_no_reflow, each 2/2 passed.Closes #169