Skip to content

Use future lazy val encoding #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ybasket wants to merge 3 commits into from
Closed

Use future lazy val encoding #809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f57e4d
Use future lazy val encoding
ybasket Sep 27, 2026
3f3686b
Attempt to make MiMa happy on future lazy vals
ybasket Sep 28, 2026
e2c4e6e
Do not use future lazy vals on Native yet
ybasket Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ val commonSettings = List(
}
.toList
.flatten,
// Scala Native's nscplugin for 3.3.8 cannot handle VarHandle-based lazy vals (scala-native/scala-native#4957)
scalacOptions ++= {
if (scalaBinaryVersion.value == "3" && !crossProjectPlatform.?.value.contains(NativePlatform))
List("-Yfuture-lazy-vals")
else Nil
},
scalacOptions ++= PartialFunction
.condOpt(CrossVersion.partialVersion(scalaVersion.value)) {
case Some((2, n)) if n >= 13 =>
Expand Down Expand Up @@ -205,7 +211,9 @@ lazy val csv = crossProject(JVMPlatform, JSPlatform, NativePlatform)
description := "Streaming CSV manipulation library",
mimaBinaryIssueFilters ++= List(
// Static forwarder, only relevant for Java
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.csv.RowEncoderF.fromNonEmptyMapCsvRowEncoder")
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.csv.RowEncoderF.fromNonEmptyMapCsvRowEncoder"),
// Static initializer forwarder, not callable. Scala 3 only, due to future lazy val encoding
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.csv.CellDecoder.<clinit>")
)
)
.jsSettings(
Expand Down Expand Up @@ -316,7 +324,11 @@ lazy val json = crossProject(JVMPlatform, JSPlatform, NativePlatform)
ProblemFilters.exclude[MissingClassProblem]("fs2.data.json.jsonpath.internals.TaggedJson$StartArrayElement$"),
ProblemFilters.exclude[MissingClassProblem]("fs2.data.json.jsonpath.internals.TaggedJson$StartObjectValue"),
ProblemFilters.exclude[MissingClassProblem]("fs2.data.json.jsonpath.internals.TaggedJson$StartObjectValue$"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.json.jsonpath.package.untag")
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.json.jsonpath.package.untag"),
// Static initializer forwarders, not callable. Scala 3 only, due to future lazy val encoding
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.json.Selector.<clinit>"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.json.NamePredicate.<clinit>"),
ProblemFilters.exclude[DirectMissingMethodProblem]("fs2.data.json.IndexPredicate.<clinit>")
)
)
.nativeSettings(
Expand Down
Loading