Repository navigation
ci(docker): publish multi-arch image to Docker Hub and document v0.5 migration - #244
goniszewski wants to merge 1 commit into
Conversation
…0.5 migration docs (#217)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| with: | ||
| ref: ${{ github.event_name == 'workflow_dispatch' && inputs.ref || github.ref }} | ||
|
|
||
| - uses: docker/setup-qemu-action@v3 |
| ref: ${{ github.event_name == 'workflow_dispatch' && inputs.ref || github.ref }} | ||
|
|
||
| - uses: docker/setup-qemu-action@v3 | ||
| - uses: docker/setup-buildx-action@v3 |
| - uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Log in to Docker Hub | ||
| uses: docker/login-action@v3 |
|
|
||
| - name: Compute tags and labels | ||
| id: meta | ||
| uses: docker/metadata-action@v5 |
| type=raw,value=latest,enable=${{ github.event_name == 'workflow_dispatch' && inputs.promote_latest }} | ||
|
|
||
| - name: Build and push | ||
| uses: docker/build-push-action@v6 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7e2b98f62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| grimoire migrate inspect --archive grimoire-v05-data.tar.gz | ||
| grimoire migrate apply --archive grimoire-v05-data.tar.gz --owner YOUR_USERNAME --dry-run | ||
| grimoire migrate apply --archive grimoire-v05-data.tar.gz --owner YOUR_USERNAME --yes |
There was a problem hiding this comment.
Following this migration procedure leaves the archive on the host, but the container only mounts grimoire-data:/data. The host CLI does not upload the archive: daemon/src/cli.ts resolves --archive to an absolute host path and sends that path as JSON, while daemon/src/migrate/legacy-paths.ts requires the file to exist in the daemon's filesystem. Consequently, inspect and apply fail with archivePath not found in the documented Docker setup. The CLI help confirms the interface is migrate inspect --archive <data.zip|tar.gz|…>, not an upload command. Add steps to copy or mount the backup into the container and invoke migration with a container-visible path, for example by running the CLI inside the container.
Useful? React with 👍 / 👎.
Part of #217 (does not close it).
docker-publish.yml: onvX.Y.Ztags builds linux/amd64 + linux/arm64, pushesX.Y.ZandX.Ywith OCI labels, provenance and SBOM.latestis never moved automatically; only via manual dispatch withpromote_latest.docker-compose.yml: pullsgoniszewski/grimoire:${GRIMOIRE_VERSION:-1.3.1};build:retained.docs/docker-deployment.md: tag policy and v0.5 -> 1.x migration (/app/data -> /data) using the existing inspect / dry-run / apply workflow.Not done / needs maintainer
DOCKERHUB_USERNAME/DOCKERHUB_TOKENrepo secrets.legacy-v0.5on Docker Hub before anylatestmove.1.3.1doesn't exist on Docker Hub until the workflow runs for that tag.