Repository navigation
Correct terminal intervals in volume rendering - #225
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Author
|
Any feedback on the volume-rendering endpoint correction? The workflow is still waiting for maintainer approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nonuniform sample depths,
volume_renderingreuses the first gap at the far endpoint. For depths[0, 1, 4], this produces intervals[1, 2, 2]instead of[1, 2, 3], changing the final sample's opacity, rendered values, and depth.Use the adjacent final gap instead. Update the existing test fixture and add independent numerical regressions covering increasing/decreasing spacing, uniform and two-sample controls, batched rays, JIT, and
opaque_final_sample.Validation:
python -m pytest -q jax3d/math/volume_rendering_test.pypasses all 71 tests. Eight nonuniform regression cases fail on unchanged upstream; the eight control cases already pass. Syntax compilation andgit diff --checkalso pass.