Skip to content

Remove full output comparison assertion in create_local_image_test #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ser-io wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −17
Open

Remove full output comparison assertion in create_local_image_test #3169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions e2etests/orchestration/create_local_image_test/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,32 +81,23 @@ func TestInstance(t *testing.T) {
EnvConfig: envConfig,
}

got, createErr := srv.CreateCVD(createReq, &hoclient.AccessTokenBuildAPICreds{})
res, createErr := srv.CreateCVD(createReq, &hoclient.AccessTokenBuildAPICreds{})

if err := common.DownloadHostBugReport(srv, group_name); err != nil {
t.Errorf("failed creating bugreport: %s\n", err)
}
if createErr != nil {
t.Fatal(createErr)
}
if err := common.VerifyLogsEndpoint(baseURL, group_name, "1"); err != nil {
t.Fatalf("failed verifying /logs endpoint: %s", err)
if len(res.CVDs) != 1 {
t.Fatalf("expected 1 cvd, got: %d", len(res.CVDs))
}
want := &hoapi.CreateCVDResponse{
CVDs: []*hoapi.CVD{
{
Group: group_name,
Name: "1",
Status: "Running",
Displays: []string{"720 x 1348 ( 280 )"},
WebRTCDeviceID: "cvd-1",
ADBSerial: "127.0.0.1:6520",
ADBPort: 6520,
},
},
cvd := res.CVDs[0]
if diff := cmp.Diff(group_name, cvd.Group); diff != "" {
t.Errorf("group name mismatch (-want +got):\n%s", diff)
}
if diff := cmp.Diff(want, got); diff != "" {
t.Errorf("response mismatch (-want +got):\n%s", diff)
if diff := cmp.Diff("Running", cvd.Status); diff != "" {
t.Errorf("status mismatch (-want +got):\n%s", diff)
}
}

Expand Down
Loading