bazel 7 readiness test - #3171
Conversation
Signed-off-by: Ying-Chun Liu <liupa@google.com>
We also modify workflows/presubmit.yaml to run this action. Signed-off-by: Ying-Chun Liu <liupa@google.com>
| --- a/base/cvd/MODULE.bazel 2026-09-10 21:48:00.155816566 +0000 | ||
| +++ b/base/cvd/MODULE.bazel 2026-09-10 21:48:00.156377436 +0000 |
There was a problem hiding this comment.
The changes to MODULE.bazel and build_external.MODULE.bazel seem very brittle, like we'll run into merge conflicts with these patches on practically any change to these files. Is there any way to reduce the change surface here?
It's not a quick fix but I was looking at converting some of the git_repository dependencies to bazel_deps in #3172 and #3173 which might align better with the override_module setup in run_bazel_7_readiness_test.sh.
| COPTS = BUILD_VAR_COPTS | ||
| LINKOPTS = BUILD_VAR_LINKOPTS | ||
|
|
||
| +def _fallback_macro(inherit_attrs = None, attrs = {}, implementation = None): |
There was a problem hiding this comment.
Rather than as a patch file, can this be in rules.bzl?
If I understand correctly, https://github.com/bazel-contrib/bazel_features can be used, e.g.
load("@bazel_features//:features.bzl", "bazel_features")
if not bazel_features.globals.macro:
def ...
| for i in `pwd`/tools/testutils/bazel-7-readiness/patches/*.patch; do | ||
| patch -p1 < $i | ||
| done |
There was a problem hiding this comment.
One of the nice things about the bazel 9 readiness test is that it is possible to reproduce issues locally with something like OVERRIDE_BAZEL_VERSION=9.0.0 bazel build <something>, but this script looks a lot more invasive.
What's the intended workflow here if a developer sees a presubmit failure on the github action? Running this script looks like it will make a lot of changes to their local git repository that can only be reset by git restore.
2 participants
Hi. I added bazel-7 readiness test. This is based on the Debian package we have in Debian unstable.
The patchset is reduced to only do the readiness test. Also the mock_repos are reduced too.
Please review the commits.
Thanks.