Fix crash when InferType fails on IntToPtr/AddrSpaceCast - #1654
Merged
Merged
Conversation
When using physical storage buffers, PhysicalPointerArgsPass converts pointer kernel arguments into integers and inserts inttoptr instructions in the kernel entry block to cast them back to pointers. If such a pointer is only passed to an undefined function declaration (such as in OpenCL CTS test `link_error_returns_program`), clspv's opaque pointer type inference cannot deduce the pointee type and InferType returns nullptr. In SPIRVProducerPass::GenerateInstruction, an assertion `assert(Ty)` caused the compiler to abort rather than reaching HandleDeferredInstruction to cleanly report the link error. Similar to the fallback used in PhysicalPointerArgsPass, fall back to i32 when InferType cannot determine the pointee type for IntToPtr or AddrSpaceCast. The undefined function call is then safely deferred and subsequently caught and reported by HandleDeferredInstruction. Add a regression test in test/PhysicalStorageBuffers/undefined_function.cl.
alan-baker
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using physical storage buffers, PhysicalPointerArgsPass converts pointer kernel arguments into integers and inserts inttoptr instructions in the kernel entry block to cast them back to pointers.
If such a pointer is only passed to an undefined function declaration (such as in OpenCL CTS test
link_error_returns_program), clspv's opaque pointer type inference cannot deduce the pointee type and InferType returns nullptr. In SPIRVProducerPass::GenerateInstruction, an assertionassert(Ty)caused the compiler to abort rather than reaching HandleDeferredInstruction to cleanly report the link error.Similar to the fallback used in PhysicalPointerArgsPass, fall back to i32 when InferType cannot determine the pointee type for IntToPtr or AddrSpaceCast. The undefined function call is then safely deferred and subsequently caught and reported by HandleDeferredInstruction.
Add a regression test in test/PhysicalStorageBuffers/undefined_function.cl.