Don't bind closures that capture lifetimes in a function return type. - #2007
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Because we generate a little bit of glue code around closures that will wrap them in a temporary closure at thunk boundaries, lifetimes in those closures were causing borrow checker errors in generated code. Specifically when a closure involved a lifetime that also appeared in the return type of the function. Fix this by preventing bindings in those cases. PiperOrigin-RevId: 981256199
copybara-service
Bot
force-pushed
the
test_981256199
branch
from
September 14, 2026 21:05
cec4710 to
d8b6bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't bind closures that capture lifetimes in a function return type.
Because we generate a little bit of glue code around closures that will
wrap them in a temporary closure at thunk boundaries, lifetimes in those
closures were causing borrow checker errors in generated code.
Specifically when a closure involved a lifetime that also appeared in
the return type of the function. Fix this by preventing bindings in
those cases.