Update symbol_canonical_name to return Result. - #2008
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_981263761
branch
2 times, most recently
from
September 14, 2026 21:27
64b89b9 to
eab7a13
Compare
Return a result from symbol_canonical_name so that it can report a more accurate error on why a symbol does not have a canonical name. Previously, we had logic littered around the codebase to turn None into an error. We can centralize all that logic by returning the error from symbol_canonical_name and provide a more descriptive error. PiperOrigin-RevId: 981263761
copybara-service
Bot
force-pushed
the
test_981263761
branch
from
September 14, 2026 22:17
eab7a13 to
d41eb88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update symbol_canonical_name to return Result.
Return a result from symbol_canonical_name so that it can report a more
accurate error on why a symbol does not have a canonical name.
Previously, we had logic littered around the codebase to turn None into
an error. We can centralize all that logic by returning the error from
symbol_canonical_name and provide a more descriptive error.