Fix thunk parameter name collision with enum variants - #2009
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_981248963
branch
2 times, most recently
from
September 14, 2026 22:29
2c0b1d0 to
9864853
Compare
When an input parameter to a function has the same name as a variant of
its enum type (e.g., parameter named `some`, `none`), rename it to
`__param_{i}` in thunk generation to prevent identifier resolution
collisions in the generated thunk code.
PiperOrigin-RevId: 981403689
copybara-service
Bot
force-pushed
the
test_981248963
branch
from
September 14, 2026 22:46
9864853 to
ee945cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thunk parameter name collision with enum variants
When an input parameter to a function has the same name as a variant of
its enum type (e.g., parameter named
some,none), rename it to__param_{i}in thunk generation to prevent identifier resolutioncollisions in the generated thunk code.