Repository navigation
Fix crashes in CompiledExpression::Compile when compiling malformed FHIRPath expressions: - #576
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1005385007
branch
from
October 27, 2026 07:21
d0e6ef4 to
7e99146
Compare
… FHIRPath expressions: 1. Catch `std::exception` when invoking ANTLR so invalid UTF-8 input strings return `absl::InvalidArgumentError` instead of throwing an uncaught `antlr4::IllegalArgumentException`. 2. Add child vector bounds checks and null checks in `FhirPathCompilerVisitor` methods so incomplete ANTLR parse trees (such as `"%"` or `"-%"`) return an error instead of aborting. PiperOrigin-RevId: 1007865079
copybara-service
Bot
force-pushed
the
test_1005385007
branch
from
October 29, 2026 09:06
7e99146 to
1f8f3e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crashes in
CompiledExpression::Compilewhen compiling malformed FHIRPath expressions:std::exceptionwhen invoking ANTLR so invalid UTF-8 input strings returnabsl::InvalidArgumentErrorinstead of throwing an uncaughtantlr4::IllegalArgumentException.FhirPathCompilerVisitormethods so incomplete ANTLR parse trees (such as"%"or"-%") return an error instead of aborting.