Conversation
IsFixedTypedVector is a property, but IsAnyVector called it as a function. Any value that is not a vector, map or typed vector reached that call and raised "TypeError: 'bool' object is not callable".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
Ref.IsFixedTypedVectoris a property, butRef.IsAnyVectorcalls it as a function (self.IsFixedTypedVector()). Any value that is not a vector, map or typed vector reaches that call, soIsAnyVectorraisesTypeError: 'bool' object is not callableinstead of returning a bool. That includes ints, floats, strings, blobs, null and fixed typed vectors.Fix: drop the parentheses so the property is read like the other two checks on the same line.
Test:
_check_intnow assertsIsAnyVectoris False and_check_fixed_typed_vectorasserts it is True. Before the fix,python py_flexbuffers_test.pyfails with 560 subtest errors in test_int, test_indirect_int, test_uint, test_inidirect_uint, test_fixed_typed_vector_int and test_fixed_typed_vector_uint, all with the TypeError above. After the fix all 60 tests pass.This is the same mistake that #9181 fixes in
AsFloat; that PR does not touchIsAnyVector.