Media upload pending despite switching off "WiFi-upload only"

[jo-spek]

If in settings "Upload photos over Wi-Fi only" is checked and data have been collected, unchecking it does not trigger the upload over mobile data.

This is a big problem at the moment for a geolocation campaign in Nigeria, where several data collectors had "Upload photos over Wi-Fi only" checked. After unchecking it, the photos keep pending in Data sync status and are never uploaded. (Once connecting to a WiFi, the photos are uploaded immediately. The Nigerian campaign is trying a workaround, connecting to hotspots, but this needs urgent fixing, therefore P0.)

Tried on older version, this seems to be an old undetected bug.

@andreia-ferreira @rfontanarosa @gino-m @shobhitagarwal1612 @kenstershiro

Andreia is on leave. Are you @shobhitagarwal1612 or somebody else available to fix this?

wifi_only_bug.mp4

[jo-spek]

Relates somewhat to #3108.

[shobhitagarwal1612]

I can take this one up.

[jo-spek]

I can take this one up.

Great, thank you!!

[shobhitagarwal1612]

PTAL #3946

[kenstershiro]

@gino-m or @rfontanarosa are you able to review the above PR in the absence of Andreia? Would then need a test build of the app cut for @jo-spek to test in the app.