Conversation
rjodinchr
force-pushed
the
dev
branch
5 times, most recently
from
July 29, 2026 15:24
e58e3e4 to
be458d5
Compare
- Fix host memory leak of `cl_event` in `clEnqueueNDRangeKernel` by using stack allocation when the caller passes a null event pointer. - Fix data race on program/kernel maps by resolving and copying names to `callback_data` at enqueue time instead of accessing maps from the helper thread. - Fix teardown race condition and potential deadlock in `clReleaseCommandQueue` by tracking pending callbacks, releasing `g_lock` before joining the thread, and verifying queue validity in the callback. - Add safety check for `clGetDeviceAndHostTimer` to prevent crashes on OpenCL 1.2/2.0 implementations. - Add missing `<stdlib.h>` include to `tests/host.c`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cl_eventinclEnqueueNDRangeKernelby using stack allocation when the caller passes a null event pointer.callback_dataat enqueue time instead of accessing maps from the helper thread.clReleaseCommandQueueby tracking pending callbacks, releasingg_lockbefore joining the thread, and verifying queue validity in the callback.clGetDeviceAndHostTimerto prevent crashes on OpenCL 1.2/2.0 implementations.<stdlib.h>include totests/host.c.