fix(aes-gcm): validate browser tag lengths - #385
Open
harrshita123 wants to merge 1 commit into
Open
Conversation
harrshita123
marked this pull request as ready for review
August 28, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperationErrorfor invalid values, matching the native backendFixes #384
Testing
dart format lib/src/impl_js/impl_js.aesgcm.dart lib/src/testing/regression/aes_gcm_invalid_tag_length.dart lib/src/testing/testing.dartdart analyze --fatal-warnings .dart test -p vm(1,460 passed, 1 existing skip)dart test test/webcrypto_test.dart -p chrome -c dart2js(1,441 passed)dart test test/webcrypto_test.dart -p chrome -c dart2wasm(1,441 passed)Firefox was not available locally; the repository CI browser matrix provides that coverage.