Repository navigation
feat(firestore): add x-goog-is-transaction routing header - #15990
Merged
amanda-tarafa merged 3 commits intoOct 23, 2026
Merged
amanda-tarafa merged 3 commits into
amanda-tarafa merged 3 commits into
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the x-goog-is-transaction header to Firestore RPC calls, indicating whether a request is part of a transaction. It updates FirestoreClientImpl to apply this header dynamically and adapts the test suite to verify its presence. The review feedback suggests optimizing ApplyTransactionHeader by removing redundant duplicate-header checks and metadata allocations, which would also allow simplifying the associated unit tests.
nikhilchowdary
force-pushed
the
feat-firestore-tx-routing-header
branch
from
October 17, 2026 08:09
28977b7 to
3ad772e
Compare
amanda-tarafa
requested changes
Oct 19, 2026
efevans
self-requested a review
October 19, 2026 17:54
nikhilchowdary
force-pushed
the
feat-firestore-tx-routing-header
branch
from
October 22, 2026 07:10
3ad772e to
e5e9dba
Compare
nikhilchowdary
force-pushed
the
feat-firestore-tx-routing-header
branch
from
October 22, 2026 07:12
e5e9dba to
90931a2
Compare
amanda-tarafa
requested changes
Oct 22, 2026
amanda-tarafa
approved these changes
Oct 23, 2026
amanda-tarafa
requested changes
Oct 23, 2026
amanda-tarafa
left a comment
amanda-tarafa
left a comment
Contributor
There was a problem hiding this comment.
Tests are failing.
efevans
removed their request for review
October 23, 2026 16:47
…ction header tests
amanda-tarafa
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add x-goog-is-transaction routing header in .NET SDK to differentiate transactional requests and non-transactional requests from firestore. Having a routing header for transactions helps in routing grpc requests at GFE.