Repository navigation
fix(Google.Cloud.Storage.V1): configure retry options in DeleteObject overloads taking an Object - #16018
Closed
robertvoinescu-work wants to merge 1 commit into
Closed
fix(Google.Cloud.Storage.V1): configure retry options in DeleteObject overloads taking an Object#16018robertvoinescu-work wants to merge 1 commit into
robertvoinescu-work wants to merge 1 commit into
Conversation
… overloads taking an Object
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the CreateDeleteObjectRequest method in StorageClientImpl.DeleteObject.cs to delegate request creation to the overloaded method taking bucket and name strings, reducing code duplication. Additionally, it adds corresponding unit tests in StorageClientImplRetryTest.cs to verify retry behaviors (NoRetry, RetryOnce, and RetryThenFail) when deleting objects using an Object instance. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/577027028