test: add LoadViewsFrom named-template rendering coverage (framework#989) - #148
Open
goravel-coder wants to merge 1 commit into
Open
test: add LoadViewsFrom named-template rendering coverage (framework#989)#148goravel-coder wants to merge 1 commit into
goravel-coder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
View().LoadViewsFrom()on a new/package-authroute, so package view directories work end-to-end over HTTP.TestLoadViewsFrom_NamedTemplate) inHttpTestSuitethat asserts the named template renders correctly under both the gin and fiber drivers.LoadViewsFrom()(fix: [#989] defer view template compilation to first serve call gin#241, fix: defer default view template compilation to first Run/Listen/Test call fiber#296).Closes goravel/goravel#989
Why
View().LoadViewsFrom()lets packages register their own view directories, but the gin and fiber drivers were silently dropping named templates ({{ define "auth.tmpl" }}) loaded from those directories. This change pins the fixing driver commits and adds an end-to-end test proving the behavior under both drivers.The template
auth.tmplexists only in theLoadViewsFrom-registered directory, so before the driver fixes/package-authreturned nothing; with the pinned fixes it renders under both drivers, and the test locks that behavior in.