Repository navigation
feat: support all CLAP2 model sizes - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Published checkpoint maximum absolute embedding errors
Published-checkpoint tolerance remains 8e-5. The synthetic asymmetric-head64
multiplepure-tone case alone has an explicit 2e-4 waveform tolerance: F32 MKL FFT residuals near the −100 dB clamp differ from native double FFT. Independent boundary injection gave <3e-7 tower error with identical official mel, and Torch double FFT reproduced native-like differences. Text, other waveform cases and published thresholds are unchanged; negative probes confirmed their strict checks still reject altered outputs. No production FFT or inference behavior was changed.Independent frontend/tower boundary evidence
For the unchanged asymmetric-head64
multipleinput and weights:The worst near-floor mel bin differed by 0.28366 dB (native −99.24464, Torch −99.52831). Exact Torch Hann with native double FFT still showed the discrepancy; official double FFT reproduced native-like results. This evidence was independently reviewed using retained raw mel artifacts. It is not presented as a production inference change.
CLAP2 block quantization is not added by this change. Cross-platform CI status is reported separately from the local/published checks above.
Remote CI
Commit
8f0e96680c61c96edc9c2a5493fe88368c0af1f0, run42484177700: 9/9 checks passed.