Skip to content

support Milvus and Weaviate connection options - #1417

Merged
zhenghaoz merged 2 commits into
gorse-io:masterfrom
zhangzhenghao:fix/database-client-options
Oct 26, 2026
Merged

zhenghaoz merged 2 commits into
gorse-io:masterfrom
zhangzhenghao:fix/database-client-options

Conversation

@zhangzhenghao

Copy link
Copy Markdown
Collaborator

Summary

Follow up on #1416 by auditing connection-option forwarding across storage backends.

  • Milvus: forward URI credentials and database path; support username, password, dbName, apiKey, enableTLSAuth and dialTimeout query options.
  • Weaviate: support apiKey, timeout and startupTimeout while preserving HTTP/HTTPS scheme selection.
  • Validate boolean/duration/query values without overriding omitted SDK defaults.
  • Add standalone parsing tests and update compact URI examples.
  • SQL, MongoDB and Redis already forward parsed client options; retain their intentional application overrides. Blob locators use separate connection configuration and are outside this change.

Validation

  • gofmt and git diff --check completed.
  • Per maintainer request, local testing was stopped and no passing final-patch test run is claimed. The initial Weaviate test attempt before implementation failed because the new parser did not yet exist.
  • CI is pending.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.44%. Comparing base (a070459) to head (f3ac0f2).

Files with missing lines Patch % Lines
storage/vectors/milvus.go 91.42% 3 Missing ⚠️
storage/vectors/weaviate.go 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   78.17%   78.44%   +0.27%     
==========================================
  Files          93       93              
  Lines       16699    16746      +47     
==========================================
+ Hits        13055    13137      +82     
+ Misses       3644     3609      -35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhenghaoz zhenghaoz changed the title fix(storage): pass Milvus and Weaviate connection options support Milvus and Weaviate connection options Oct 26, 2026
@zhenghaoz
zhenghaoz merged commit 44791ec into gorse-io:master Oct 26, 2026
12 checks passed
AyushSh911 added a commit to AyushSh911/gorse that referenced this pull request Nov 2, 2026
* commit '2145bd0567f03b59f83f43ea2575a17a9bdaa016':
  refactor(log): unify events with dynamic zap fields (gorse-io#1421)
  refactor: remove unused ANN implementation (gorse-io#1422)
  support Milvus and Weaviate connection options (gorse-io#1417)
  support qdrant client options (gorse-io#1416)
  build: keep Go build caches in Docker layers (gorse-io#1413)
  ci: move Docker build caches to GHCR (gorse-io#1412)
  fix(build): pass Windows linker flags through PowerShell (gorse-io#1410)
  build: share compilation and pass build info externally (gorse-io#1409)
  Move Gorse CLI to gorse-io/cli (gorse-io#1408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants