Skip to content

refactor: remove unused ANN implementation - #1422

Merged
zhenghaoz merged 1 commit into
masterfrom
remove-unused-ann
Oct 29, 2026
Merged

zhenghaoz merged 1 commit into
masterfrom
remove-unused-ann

Conversation

@zhangzhenghao

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the unused common/ann package.
  • Remove MatrixFactorizationItems, its distance helper, and its obsolete test.
  • Preserve MatrixFactorizationUsers and its existing test; production collaborative filtering uses vector storage.

Verification

  • go test ./logics passed.
  • git diff --check passed.
  • Repository search found no remaining common/ann or MatrixFactorizationItems references.
  • Whole-repository compile check (go test ./... -run '^$') timed out locally; not confirmed passing.

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.03%. Comparing base (44791ec) to head (6f66622).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   78.37%   78.03%   -0.34%     
==========================================
  Files          93       91       -2     
  Lines       16730    16427     -303     
==========================================
- Hits        13112    12819     -293     
+ Misses       3618     3608      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhenghaoz
zhenghaoz merged commit 670c53f into master Oct 29, 2026
12 of 13 checks passed
@zhenghaoz
zhenghaoz deleted the remove-unused-ann branch October 29, 2026 19:15
AyushSh911 added a commit to AyushSh911/gorse that referenced this pull request Nov 2, 2026
* commit '2145bd0567f03b59f83f43ea2575a17a9bdaa016':
  refactor(log): unify events with dynamic zap fields (gorse-io#1421)
  refactor: remove unused ANN implementation (gorse-io#1422)
  support Milvus and Weaviate connection options (gorse-io#1417)
  support qdrant client options (gorse-io#1416)
  build: keep Go build caches in Docker layers (gorse-io#1413)
  ci: move Docker build caches to GHCR (gorse-io#1412)
  fix(build): pass Windows linker flags through PowerShell (gorse-io#1410)
  build: share compilation and pass build info externally (gorse-io#1409)
  Move Gorse CLI to gorse-io/cli (gorse-io#1408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants