You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This Pull Request includes changes to the following packages.
Package
Version
trackio
minor
Fix dotted metric names in line plots
Something isn't right?
Maintainers can change the version label to modify the version bump.
If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.
profiling/reference_metric renders; profiling/Time taken: GRPOTrainer.compute_loss is empty
After
Both profiling metrics render
Both Spaces use byte-identical app.py files and serve the same 12 values for each metric. The after Space serves the exact frontend bundle built from this branch.
The reason will be displayed to describe this comment to others. Learn more.
Not a trackio expert but this looks right to me. I checked escapeVegaField against vega-util's splitAccessPath and it round-trips profiling/Time taken: GRPOTrainer.compute_loss back to the literal key, and every field: in the spec looks covered.
One thing I wasn't sure about: quotes aren't escaped. splitAccessPath seems to enter quote mode whenever i === b, which for a field with no dots holds at every position, so something like say "hi" would still break. vega-lite's replacePathInField uses /(\[|\]|\.|'|")/g. Might be worth the union, though it doesn't affect us, our metric names come from Python identifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677.
Summary
Verification
cd trackio/frontend && npm testcd trackio/frontend && npm run lintcd trackio/frontend && npm run buildcd trackio/frontend && node repro_issue_677_vega.mjsMinimal reproduction
The reproduction files are intentionally untracked and were not committed.