Don't drop "inherit" flag from standard stream handles on Windows - #409
Open
mlopatkin wants to merge 1 commit into
Open
Don't drop "inherit" flag from standard stream handles on Windows#409mlopatkin wants to merge 1 commit into
mlopatkin wants to merge 1 commit into
Conversation
This was a useful workaround for ancient Java versions that prevented standard streams from unintentionally leaking into unrelated processes started by ProcessBuilder. As of Java 8 (and final updates of 7), the JDK itself handles that, see https://bugs.openjdk.org/browse/JDK-7147084 The native-platform is Java 8+ today, so the workaround is no longer necessary. Moreover, it is known to cause issues when the standard stream handles go stale, in particular when Gradle daemon closes its System.out and System.err without updating the native side.
mlopatkin
marked this pull request as draft
August 12, 2026 13:52
mlopatkin
marked this pull request as ready for review
August 12, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a useful workaround for ancient Java versions that prevented standard streams from unintentionally leaking into unrelated processes started by ProcessBuilder.
As of Java 8 (and final updates of 7), the JDK itself handles that, see https://bugs.openjdk.org/browse/JDK-7147084
The native-platform is Java 8+ today, so the workaround is no longer necessary. Moreover, it is known to cause issues when the standard stream handles go stale, in particular when Gradle daemon closes its System.out and System.err without updating the native side.