An installation without compiled DI metadata serves requests - #3
Merged
Merged
Conversation
AreaConfigLoader included generated/metadata/<area>.php in every case. Without setup:di:compile, as in developer mode, every request failed on the missing file. The loader now hands such an installation to the runtime loader of Magento.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by 🤖:
AreaConfigLoader::load()includedgenerated/metadata/<area>.phpin every case. On an installation withoutsetup:di:compile, as in developer mode, each web request failed:Reproduced on Mage-OS 3.4.0 in developer mode with
GraphCommerce_FastBootenabled:POST /graphqlreturns 500, andfastboot:preparefails with the same error.The loader now reads the di.xml files through
Magento\Framework\App\ObjectManager\ConfigLoader, the runtime loader of Magento, when the area file or the global file is absent. With compiled metadata nothing changes. A unit test covers the fallback.