Entries that Mage-OS compresses in Redis reach the local files - #5
Merged
Merged
Conversation
The lifetime rule compared the packed record with the value the frontend answered, so every entry above the compression threshold, among them the translations, the EAV attributes and most config data, stayed a Redis read per request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by 🤖:
Mage-OS 3.5 wraps a Redis frontend with
compress_datain its compression decorator: a string above 2 KB is stored packed with theCACHE_COMPRESSIONprefix.EntryLifetimecompared that packed record with the value the frontend answered, so the comparison failed for every such entry andcache_filespromoted none of them: the translations, the EAV attribute preload, the product types, the extension attributes and the GraphQL config stayed a Redis read per request.The rule unpacks the record the way the decorator does before it compares. Measured on a shop with
compress_dataon: Redis commands per warm GraphQL request went from 54 to 29, the rest are the bootstrap reads before interception and the version token.The unit test stores an entry through the decorator and expects its expiry back.