A configuration value is resolved once per request - #8
Merged
Merged
Conversation
The second read of a value by scope, scope code and path answers from a request memo, so a page that reads the same settings per card skips the scope resolution and the type lookup for them. A configuration clean, a mutable set and a switch of the current store empty the memo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by 🤖:
ValueMemoanswers the second read of a configuration value by scope, scope code and path from a request memo, under theconfig_memoswitch. A read with a scope object as code is not memoised. A configuration clean, a mutable set and a switch of the current store empty the memo, and the memo resets after a request in a worker.On a Luma search page with 176 configurables the configuration reads went from 7% to 2% of the render. The rendered parity gate stays identical.
🤖 Generated with Claude Code