Skip to content

fix: allow boolean column sort configuration - #1512

Open
sridharkalaibala wants to merge 1 commit into
grid-js:masterfrom
sridharkalaibala:fix/column-sort-boolean-type
Open

sridharkalaibala wants to merge 1 commit into
grid-js:masterfrom
sridharkalaibala:fix/column-sort-boolean-type

Conversation

@sridharkalaibala

Copy link
Copy Markdown

Summary

Allows TColumn.sort to be boolean | SortConfig, matching the documented configuration and existing header normalization. A typed column with sort: true or sort: false currently fails with TS2559 even though those settings work at runtime.

The table header now narrows object-valued sort configuration before accessing compare or passing plugin props. Adds typed header coverage and a rendered-table test for enabled/disabled columns and custom comparator forwarding on clicks.

Fixes #1510.

Validation

  • New typed regression fails on upstream with TS2559 for both boolean values; passes after the change.
  • Full Jest suite: 194 tests and 36 snapshots passed across 34 suites.
  • Full ESLint: zero errors, 36 warnings; changed-file check has only the existing Plugin<any> warning. Changed files pass Prettier and git diff --check.
  • Release type check reports six dependency declaration errors, verified identical on upstream and patched source. Declaration generation with --skipLibCheck succeeds and emits sort?: boolean | SortConfig.
  • Browser E2E and complete bundle/plugin build were not run. No dependency or lockfile changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TColumn.sort Has Wrong Definition

1 participant