Skip to content

Compare producer stop markers by identity - #377

Merged
grosser merged 3 commits into
grosser:masterfrom
OskarEichler:codex/compare-stop-by-identity
Aug 28, 2026
Merged

Compare producer stop markers by identity#377
grosser merged 3 commits into
grosser:masterfrom
OskarEichler:codex/compare-stop-by-identity

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Recognize only the Parallel::Stop object as the producer terminator.

Reproduction and verification

A producer yielding an ordinary object whose == method returns true currently stops without processing it. Stop is a unique sentinel, so its identity must be compared rather than delegating equality to the item.

A finite producer fixture with custom equality fails before and passes after. Fifteen existing producer/queue examples pass.

The combined installed-release candidate passes 800 model checks across direct, thread, process and Ractor modes. Existing selected suite: 165 examples, zero failures, nine pending, baseline and candidate on rbenv Ruby 4.0.6. Global process-name kill tests and the 200-process stress example were excluded for shared-host safety. SQLite examples use temporary databases. An external verification bundle uses already-installed dependencies; upstream Gemfile/lockfile/tests remain unchanged.

Runtime RuboCop passes. Full upstream RuboCop reports the same pre-existing RSpec/MatchWithSimpleRegex offense in spec/parallel_spec.rb:278 on both versions; no full green-lint claim. Gem packaging retains 2.1.0, Ruby >= 3.3, all four published paths and metadata, with no dependency changes.

Compatibility and limitations

Items merely no longer impersonate Stop via custom equality. Returning Parallel::Stop still terminates production; no producer scheduling change.

No tests were added or modified under the consuming repository's no-new-tests policy. Reproductions/model checks are external scratch scripts. No production operations or claim of complete concurrency/platform coverage.

@grosser grosser left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit far-fetched but technically correct 👍

@grosser
grosser merged commit 1512889 into grosser:master Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants