Skip to content

Honor Ractor callbacks in direct mode - #384

Closed
OskarEichler wants to merge 1 commit into
grosser:masterfrom
OskarEichler:codex/direct-ractor-callbacks
Closed

Honor Ractor callbacks in direct mode#384
OskarEichler wants to merge 1 commit into
grosser:masterfrom
OskarEichler:codex/direct-ractor-callbacks

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Validate Ractor callback usage before worker-count dispatch and execute the configured callback in zero-worker direct mode.

External map, indexed map, each, and invalid-combination models pass on Ruby 4.0.6 and 3.2.11. Diff and syntax checks pass. Source only; repository tests are unchanged.

@OskarEichler
OskarEichler force-pushed the codex/direct-ractor-callbacks branch from 84e6c99 to eba807d Compare August 30, 2026 09:21
@grosser

grosser commented Aug 30, 2026

Copy link
Copy Markdown
Owner

I think I fixed that with some previous PRs already, lmk if any work remains

@grosser grosser closed this Aug 30, 2026
@OskarEichler

Copy link
Copy Markdown
Contributor Author

Confirmed against current master: the empty-input/direct path now replaces the block with ractor_block(options) before calling work_direct, so it preserves the ractor: [Class, :method] contract and its validation without the additional dispatch code from this PR. No further change is needed here. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants