Clean up partially created process workers - #387
Merged
grosser merged 1 commit intoAug 30, 2026
Conversation
grosser
approved these changes
Aug 30, 2026
| workers << worker(job_factory, options.merge(started_workers: workers, worker_number: i), &block) | ||
| end | ||
| workers | ||
| rescue Exception # rubocop:disable Lint/RescueException |
Owner
There was a problem hiding this comment.
this seems good/clean, a test would be nice though
(make workers have some side-effect + make em crash -> no sideeffect observed)
| child_write.close | ||
|
|
||
| Worker.new(parent_read, parent_write, pid, options[:serializer]) | ||
| rescue Exception # rubocop:disable Lint/RescueException |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close partial pipes and stop/reap child processes when worker creation fails, including workers created before a later failure.
An external injected-failure model passes on Ruby 4.0.6 and 3.2.11. Diff and syntax checks pass. Source only; repository tests are unchanged.