Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing query parameters with an iterator over the query鈥檚 own keys raises
RuntimeError: OrderedDict mutated during iteration. This also affects filtered generators over those keys and can leave a partially modified query.Snapshot iterable keys or items before removal, matching the existing handling of mapping inputs. Add regressions for removing every key and filtering out a retained key; both fail before the change.
Validation: all 15 Query tests and changed-file Flake8 checks pass. The full suite has 76 passes and three legacy IPv6/URL failures on Python 3.13; the same three failures reproduce with unchanged source and the two new tests excluded (74 passes).