Repository navigation
fix: prevent phantom follow-up sync runs with "Starting Sync..." title - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a scheduled task completes successfully, an additional phantom log entry immediately appears in the sync history:
Starting Sync... sync successful - There was nothing to do. Est. Speed: 0 Б/s Avg. Speed: 0 Б/s.Cause
DatabaseHandler.taskFromCursor(),cursor.getLong()was directly called for nullable columns (onFailFollowup,onSuccessFollowup). In Android SQLite,getLong()on aNULLcolumn returns0L.followupTask()checked onlyfollowUpTaskID == null || followUpTaskID == -1L. Since the value was0L, it enqueued a follow-up task with ID0L.SyncWorker.doWork(), querying task ID0Lreturnednull. However, theelsebranch still invokedpostSync()with defaultfailureReason = NO_FAILUREand default title"Starting Sync...", falsely logging a success with 0 transferred files.Solution
DatabaseHandler.kt: Checkcursor.isNull()before readingfilterId,onFailFollowupandonSuccessFollowup, ensuring unset IDs staynull.SyncWorker.kt:followupTask()only triggers whenfollowUpTaskID > 0L.doWork()without callingpostSync()when no valid task is retrieved.