Skip to content

ci: publish development images via repository variables - #193

Merged
dimoschi merged 2 commits into
mainfrom
ci/development-image-publish
Sep 29, 2026
Merged

dimoschi merged 2 commits into
mainfrom
ci/development-image-publish

Conversation

@ToxicBiohazard

@ToxicBiohazard ToxicBiohazard commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Development and production images are both published by the shared build workflow. A push to main, a manual run, or a release-candidate tag publishes a development image. Any other version tag publishes a production image. The previous production rollout is removed.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Workflow-only change. No application code was modified.

The development and production environments need these variables before an image can be published:

  • AWS_GITHUB_ROLE
  • ECR_REPOSITORY

Release-candidate tags and manual runs push to the registry configured on the development environment. Other version tags still roll out production the same way.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.60%. Comparing base (76b2f25) to head (da5635a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files          54       54           
  Lines        3177     3177           
=======================================
  Hits         2116     2116           
  Misses       1061     1061           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Version tags and main use the same build. Production no longer rolls out through the previous cluster.

Co-authored-by: Cursor <cursoragent@cursor.com>

@dimoschi dimoschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care!

@dimoschi
dimoschi merged commit c5de404 into main Sep 29, 2026
4 checks passed
@dimoschi
dimoschi deleted the ci/development-image-publish branch September 29, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants