Repository navigation
Upgrade to Zig 0.17 and bump fcvvdp to 0.4.1 - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Zig 0.17.0, pin
simpleimgiomain at98473d1, and use the Zig 0.17 libspng 0.0.2 wrapper from gianni-rosato/libspng#1. Bump fcvvdp to 0.4.1 in both the package and public header.Compile AVX2/FMA in a separate object so generic x86_64 targets build without globally enabling AVX. Repair ELF LTO linking and report unsupported macOS LTO explicitly; the original Zig 0.16 macOS build also fails with that option. Include
c_imports.hin exported packages. The metric's C implementation and optimization flags remain unchanged.This PR contains no added tests, benchmark scripts, validation documentation, or CI. README changes only update the required Zig version and clarify ELF-only LTO support.
Validation: native arm64 macOS release and x86_64 Linux LTO cross-builds pass, as do formatting and diff checks. The resulting macOS binary is identical to the previously validated upgrade binary. Earlier correctness checks and 24 paired benchmark measurements found at most 0.000001 JOD difference and no statistically resolved runtime slowdown; peak RSS increased by 32–48 KiB.