Repository navigation
update fcvvdp + simpleimgio deps - #4
Merged
Merged
Conversation
gianni-rosato
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reported Snow and DSV2 Y4M comparisons produced CVVDP scores of 8.951164 and 8.567672, versus FFVship's 8.7961 and 8.78857. Update simpleimgio and fcvvdp, and pass float linear RGB directly to CVVDP so range, chroma position, transfer, and source sample precision survive decoding.
Other Y4M metrics use the same corrected conversion before their final sRGB8 quantization. Conversion scratch storage is reused per worker. Existing image-format paths and the public metric API are unchanged.
Validation: release build; generated CLI goldens for SD/HD, 8/10-bit, limited/full-range Y4M; all 14 Python tests; both full reported clips with matching input MD5s. FFVship goldens use Vship
7dca6ea307fb84506980ac61e99030c1773aea5fwith the local Metal backend. Companion fcvvdp validation covers scalar, NEON, AVX2, threading, and reset behavior.Dependencies: gianni-rosato/simpleimgio#1 → halidecx/fcvvdp#19 → this PR. Both dependencies are now pinned with
zig fetch --saveto their updatedmaincommits: simpleimgio6d9b55ead31a181f82595ffaed05986476510126and fcvvdp012f2243cf68ce5456705860a711db202fa5c63f. The release build, all six generated Y4M cases, and all 14 Python tests pass with these pins. The fcvvdp PR includes before/after correctness and same-machine performance tables.Python wheel CI before the main-pin update passed on Linux x86_64/aarch64 and macOS x86_64/arm64.