Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ jobs:
else
python scripts/release.py container-build
fi
- name: Scan container for fixable high and critical vulnerabilities
- name: Scan container and report deferred dependency vulnerabilities
run: |
mkdir -p dist/security
scanner_dir="$RUNNER_TEMP/metapathways-trivy"
Expand All @@ -250,8 +250,17 @@ jobs:
"$scanner_dir/trivy" image --scanners vuln \
--format json --output dist/security/trivy.json "$image"
"$scanner_dir/trivy" image --scanners vuln \
--ignore-unfixed --severity HIGH,CRITICAL --exit-code 1 \
--ignore-unfixed --severity HIGH,CRITICAL --exit-code 0 \
--format json --output dist/security/fixable-high-critical.json "$image"
python - <<'PYTHON'
import json
from pathlib import Path
report = json.loads(Path('dist/security/fixable-high-critical.json').read_text())
findings = [v for r in report.get('Results', []) for v in r.get('Vulnerabilities', [])]
if findings:
ids = {v['VulnerabilityID'] for v in findings}
print(f'::warning::Deferred dependency findings: {len(findings)} occurrences, {len(ids)} unique IDs. See issue #15 and container-security-report.')
PYTHON
- name: Retain vulnerability scan report
if: always()
uses: actions/upload-artifact@v7.0.1
Expand Down
28 changes: 28 additions & 0 deletions docs/release-readiness.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,34 @@ are excluded from public packages.
- Installed-wheel assets, version, bundled test preparation, MAGSplitter CLI and Camelot import passed outside the source checkout.
- Final Conda integration and Docker/Apptainer validation remain release-build checks.

## Deferred dependency security remediation (2026-10-09)

The [4.0.0 validation run](https://github.com/hallamlab/MetaPathways/actions/runs/38000115287)
passed Conda installation and workflow integration, Docker workflow integration,
and MP Apptainer artifact checks. Third-party dependency findings are temporarily advisory under
[issue #15](https://github.com/hallamlab/MetaPathways/issues/15). This is a HallamLab release policy, not an Anaconda
upload requirement.

Trivy 0.74.0 reported 649 fixable high/critical occurrences across 89 distinct
vulnerability IDs, primarily in Apptainer and its CNI networking dependencies,
plus Java libraries bundled with Nextflow. Repeated occurrences across binaries
are not independent vulnerabilities. Individual applicability to MP has not
been established. The retained `container-security-report` artifact contains the
full and filtered JSON reports. The licensed Pathway Tools SIF was not scanned.

The tested packages were Apptainer 1.5.4, CNI 1.0.1, CNI plugins 1.3.0 and
Nextflow 26.04.7. An upstream Nextflow 26.09.2-edge candidate had no fixable
high/critical Java findings in a separate scan, but remains an untested prerelease
for MP. Official Apptainer 1.5.4 Debian binaries still had findings. No candidate
replaced the validated dependencies.

Custom dependency rebuilds are deferred. The release scanner still runs and
retains its full and filtered reports; findings produce a visible warning.
Scanner execution errors and all build/integration failures remain blocking. Track patched upstream packages,
remaining findings, and required compatibility/security validation in
[issue #15](https://github.com/hallamlab/MetaPathways/issues/15). This temporary policy does not suppress findings or imply that the dependencies
are vulnerability-free. Review it before each release until issue #15 is resolved.

## Release checks

1. Pass unit, release-control, documentation, source and wheel checks.
Expand Down
10 changes: 10 additions & 0 deletions docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -326,3 +326,13 @@ Secret values must never be committed or printed. Repository files alone cannot

```{include} includes/cami-references.md
```

## Temporary dependency-security policy

Dependency findings are temporarily advisory while
[issue #15](https://github.com/hallamlab/MetaPathways/issues/15) tracks upstream
Apptainer/CNI and Nextflow remediation. Trivy still scans every release image,
retains full and filtered JSON reports, and emits a warning for fixable high or
critical findings. Scanner execution errors, package and container builds, and
workflow validation failures still block release. Review the findings before
each publication; restore the blocking findings policy after remediation.
Loading