Repository navigation
chore: replace Travis CI with GitHub Actions - #90
Closed
dkapanidis wants to merge 2 commits into
Closed
dkapanidis wants to merge 2 commits into
dkapanidis wants to merge 2 commits into
Conversation
captain had no working CI: .travis.yml targeted Travis's now-defunct free OSS tier and go 1.6, so nothing was actually testing pushes or PRs. Add a single-workflow GitHub Actions CI (build, vet, test on every push to master and every PR), matching the org's standard delivery convention, and drop the dead Travis config and badge. Three pre-existing, environment-independent test failures are excluded via -skip so the new CI is green: TestBuildImage, TestTagImage and TestImageExist build/pull golang:1.4.2, whose Docker Hub schema-v1 manifest has been removed; TestColorCodes assumes a TTY, which CI never has. None are touched or weakened - same behavior as go test today, just not silently ignored. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011F77VXPGQCAgfcNpdDNB7f
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011F77VXPGQCAgfcNpdDNB7f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convention
From
my-dev-skill'sskills/infra-deploy/SKILL.md("CI/CD: GitHub Actions"):And
CLAUDE.md's top-level rule: "Delivery is GitHub Actions → GitHub Packages → Flux. Nothing is deployed by hand."(
captainis a standalone CLI released as downloadable binaries via GitHub Releases, not a container workload — the GHCR/Flux deployment portion of that convention doesn't apply here, only the GitHub-Actions-as-CI part.)Today vs. the convention
captainhas no working CI. Its only pipeline is.travis.yml, targetinggo: 1.6on Travis's free open-source tier, which Travis discontinued years ago — pushes and PRs to this repo are not being tested at all. That's a direct gap against the "everything runs through GitHub Actions" convention, and it's a correctness/safety gap in its own right: nothing catches a regression before merge.What this PR changes
.github/workflows/ci.yml: a single job that runsgo build,go vet, andgo teston every push tomasterand every pull request..travis.yml.The test step explicitly
-skips three pre-existing, environment-independent failures so the new CI is actually green rather than red from its first run:TestBuildImage,TestTagImage,TestImageExist— these build/pullgolang:1.4.2in their fixtures, and Docker Hub has since removed support for that image's schema-v1 manifest ("manifest version 2, schema 1 has been removed"). This fails identically in any environment, not just CI.TestColorCodes— asserts on ANSI color codes thatfatih/colordisables whenever stdout isn't a TTY, which it never is undergo test.None of these tests are modified, weakened, or deleted — the
-skiponly affects what the new CI workflow invokes;go test ./...locally behaves exactly as it does today. Verified locally:go build ./...,go vet ./..., andgo test -skip '...' ./...all pass cleanly (Docker-dependent tests included, with a localdockerd).Other gaps found (not implemented here)
missing-renovate-json: norenovate.jsonat the repo root;skills/infra-deploy/SKILL.md's Dependency updates section asks every repo to carry one extendinggithub>harbur/renovate-config. Likely explains whygo.modis pinned to dependency versions from 2017-2019. Small, mechanical — good next candidate.test-fixtures-use-removed-docker-image:docker_test.go/captain_test.gofixtures targetgolang:1.4.2andgolang:1.6, both long removed/deprecated on Docker Hub (see above). Fixing this means updating fixture Dockerfiles and re-verifying the assertions still hold — a small but separate change from the CI-runner migration itself.legacy-go-toolchain-and-deps:go.moddeclaresgo 1.12and pins many indirect dependencies to pre-Go-modules commit-hash versions (e.g.docker/docker,fsouza/go-dockerclient). It builds fine under a modern Go toolchain today, but this is a large, non-mechanical dependency bump better done as its own effort (likely unblocked by adding Renovate above).captainis a CLI tool with no HTTP API or database, not a service.🤖 Generated with Claude Code
https://claude.ai/code/session_011F77VXPGQCAgfcNpdDNB7f
Generated by Claude Code