Skip to content

spec tier, typed estimate, rollout verify, hash provenance (W2.2-W2.4 + W4.1) - #345

Draft
aarontrowbridge wants to merge 1 commit into
mainfrom
amico/spec-tier-estimate-verify-341-344
Draft

spec tier, typed estimate, rollout verify, hash provenance (W2.2-W2.4 + W4.1)#345
aarontrowbridge wants to merge 1 commit into
mainfrom
amico/spec-tier-estimate-verify-341-344

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

Roadmap plan-20260812-142100-problemspecs-issimo-roadmap W2.2-W2.4 + W4.1.

Implements #341, #342, #343, #344 in one branch.

#341 — spec tier above vetted + gate validates problemspec against entitlement-keyed variant

  • catalog.ts: spec becomes top tier (fully validated data, no authored code); out-of-subset falls through with reason; isSpecExpressible heuristic for custom objectives.
  • gate.ts: validates problem_spec inline object against vendored FULL vs OSS schema by entitlement (hasIssimoEntitlement); Piccolissimo-only integrator (exponential/spline) fails gate on OSS with structured entitlement hint.
  • @amicode/schema: register problemspec-oss with distinct $id to avoid Ajv collision; add validateProblemSpec/hasIssimoEntitlement.
  • Schemas: run/solvespec add spec tier (and hpc kept); SCORE solve-stage tier note.

#342 — estimate.ts typed spec

  • estimate.ts: add extractKeyVarsFromSpec parsing typed fields (problem.N, system.params.levels/subsystem_levels/components, pulse.T, trajectory kind, wrapper count) and share size model (unitary squares dim, ket single, sampling multiplies); keep regex path for scripts.
  • subcommands.ts: estimate --spec routes problem_spec specs via typed adapter (inline object or TOML path via smol-toml); fixtures reused.

#343 — amicode_verify v2 rollout referee

  • verify.ts: derive rollout spec via referee_rollout(control_spec, run) (strictly finer, different integrator family, forge-proof [referee] block re-validated at parse time), synchronous run (scoped exception to never-launches, produce no run_dir), record typed Verdict/Agree with witness fidelities; legacy system_verify.jld2 path retained as fallback with migration note; deriveRolloutSpec exported.

#344 — ledger hash stamp + pulse_hash provenance

  • launch.ts: when solvespec carries problem_spec, compute structureHash/problemHash in TS (@amicode/schema hashing.ts byte-exact mirror) and stamp into run.toml [hashes] alongside spec_hash.
  • local_executor.ts: emitSolveStanza falls back to run.toml [hashes] when result.toml [params] lacks keys and reads inline problem.toml as summary source.
  • repertoire.ts/catalog_verb.ts: stamp content hash of pulse.jld2 into pulse_hash (verifiable warm-start); catalog entries carry pulse_hash.

Closes #341, Closes #342, Closes #343, Closes #344

#342 #343 #344)

- #341 catalog.ts: add spec tier above vetted (fully validated data, no authored code); out-of-subset falls through with reason; gate.ts validates problem_spec against entitlement-keyed FULL/OSS schema variant (issimo -> full else OSS), making problemspec.oss.schema.json load-bearing; update solvespec/run schemas and pulse-designer SCORE solve-stage language.
- #342 estimate.ts: parse problem_spec TOML and read typed fields (problem.N, system.params.levels/subsystem_levels, trajectory kind, wrapper count) via extractKeyVarsFromSpec; share size model (unitary squaring, ket single, sampling multiplier) with regex path; subcommands.ts estimateCommand routes problem_spec specs via typed adapter, keeps regex for scripts; reuse fixtures.
- #343 verify.ts v2: derive rollout spec via referee_rollout(control_spec, run) (strictly finer, different integrator family, forge-proof [referee] block), synchronous run (scoped exception to never-launches), typed Verdict/Agree witness; legacy system_verify.jld2 path retained as fallback with migration note.
- #344 launch.ts: when solvespec carries problem_spec compute structureHash/problemHash in TS (@amicode/schema hashing.ts byte-exact mirror) and stamp into run.toml [hashes]; local_executor.emitSolveStanza falls back to run.toml when result.toml lacks keys and reads inline problem.toml; repertoire.ts/catalog_verb.ts stamp content hash of pulse.jld2 into pulse_hash for verifiable warm-start.

Roadmap plan-20260812-142100-problemspecs-issimo-roadmap W2.2-W2.4 + W4.1
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f2280959-aa5f-400c-b4f5-c0a88e280af9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment