spec tier, typed estimate, rollout verify, hash provenance (W2.2-W2.4 + W4.1) - #345
Draft
aarontrowbridge wants to merge 1 commit into
Draft
spec tier, typed estimate, rollout verify, hash provenance (W2.2-W2.4 + W4.1)#345aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
#342 #343 #344) - #341 catalog.ts: add spec tier above vetted (fully validated data, no authored code); out-of-subset falls through with reason; gate.ts validates problem_spec against entitlement-keyed FULL/OSS schema variant (issimo -> full else OSS), making problemspec.oss.schema.json load-bearing; update solvespec/run schemas and pulse-designer SCORE solve-stage language. - #342 estimate.ts: parse problem_spec TOML and read typed fields (problem.N, system.params.levels/subsystem_levels, trajectory kind, wrapper count) via extractKeyVarsFromSpec; share size model (unitary squaring, ket single, sampling multiplier) with regex path; subcommands.ts estimateCommand routes problem_spec specs via typed adapter, keeps regex for scripts; reuse fixtures. - #343 verify.ts v2: derive rollout spec via referee_rollout(control_spec, run) (strictly finer, different integrator family, forge-proof [referee] block), synchronous run (scoped exception to never-launches), typed Verdict/Agree witness; legacy system_verify.jld2 path retained as fallback with migration note. - #344 launch.ts: when solvespec carries problem_spec compute structureHash/problemHash in TS (@amicode/schema hashing.ts byte-exact mirror) and stamp into run.toml [hashes]; local_executor.emitSolveStanza falls back to run.toml when result.toml lacks keys and reads inline problem.toml; repertoire.ts/catalog_verb.ts stamp content hash of pulse.jld2 into pulse_hash for verifiable warm-start. Roadmap plan-20260812-142100-problemspecs-issimo-roadmap W2.2-W2.4 + W4.1
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap plan-20260812-142100-problemspecs-issimo-roadmap W2.2-W2.4 + W4.1.
Implements #341, #342, #343, #344 in one branch.
#341 — spec tier above vetted + gate validates problemspec against entitlement-keyed variant
catalog.ts: spec becomes top tier (fully validated data, no authored code); out-of-subset falls through with reason;isSpecExpressibleheuristic for custom objectives.gate.ts: validatesproblem_specinline object against vendored FULL vs OSS schema by entitlement (hasIssimoEntitlement); Piccolissimo-only integrator (exponential/spline) fails gate on OSS with structured entitlement hint.@amicode/schema: registerproblemspec-osswith distinct $id to avoid Ajv collision; addvalidateProblemSpec/hasIssimoEntitlement.spectier (andhpckept); SCORE solve-stage tier note.#342 — estimate.ts typed spec
estimate.ts: addextractKeyVarsFromSpecparsing typed fields (problem.N,system.params.levels/subsystem_levels/components,pulse.T, trajectory kind, wrapper count) and share size model (unitary squares dim, ket single, sampling multiplies); keep regex path for scripts.subcommands.ts:estimate --specroutes problem_spec specs via typed adapter (inline object or TOML path via smol-toml); fixtures reused.#343 — amicode_verify v2 rollout referee
verify.ts: derive rollout spec viareferee_rollout(control_spec, run)(strictly finer, different integrator family, forge-proof [referee] block re-validated at parse time), synchronous run (scoped exception to never-launches, produce no run_dir), record typed Verdict/Agree with witness fidelities; legacysystem_verify.jld2path retained as fallback with migration note;deriveRolloutSpecexported.#344 — ledger hash stamp + pulse_hash provenance
launch.ts: when solvespec carriesproblem_spec, computestructureHash/problemHashin TS (@amicode/schemahashing.ts byte-exact mirror) and stamp intorun.toml [hashes]alongside spec_hash.local_executor.ts:emitSolveStanzafalls back torun.toml [hashes]whenresult.toml [params]lacks keys and reads inlineproblem.tomlas summary source.repertoire.ts/catalog_verb.ts: stamp content hash ofpulse.jld2intopulse_hash(verifiable warm-start); catalog entries carry pulse_hash.Closes #341, Closes #342, Closes #343, Closes #344