Infer brewer palette types from names - #1123
Merged
Merged
Conversation
Named Brewer palettes now determine their own type, while numeric palettes continue to use the requested type. Unknown names raise ValueError, and scale_color_brewer(palette="Set2") works without an explicit qualitative type. The dependency update requires mizani 0.14.5. Warn when scale_color_distiller interpolates a qualitative palette, regardless of whether its type comes from the palette name or the type argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
scale_color_brewerandscale_fill_brewerinfer the palette type from its name, soscale_color_brewer(palette="Set2")works without an explicittype.scale_color_distillerandscale_fill_distillernow warn when interpolating a qualitative palette regardless of whether the type comes from the palette name or thetypeargument.It also bumps the
mizanidependency to0.14.5, which this fix requires.closes #1048