Repository navigation
fix(providers): cancel responses rejected by Content-Length - #43
Merged
haseebahmed248 merged 2 commits intoSep 7, 2026
Conversation
Signed-off-by: kudala-bharani <bunnykudala@gmail.com>
haseebahmed248
requested changes
Sep 6, 2026
haseebahmed248
left a comment
Owner
There was a problem hiding this comment.
Thanks for the focused fix and tests. The type checks, generated-contract check and all 59 tests pass, and CI is green. Catching the cleanup error is appropriate here because it must not replace the known size failure. There is one pending-cancellation case to address, noted inline.
Signed-off-by: kudala-bharani <bunnykudala@gmail.com>
haseebahmed248
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responses rejected by their
Content-Lengthleft the unread body open. Start cancelling that body and returnPROVIDER_RESPONSE_TOO_LARGEwithout waiting for cleanup to settle. Cleanup rejection is handled without replacing the known size failure.Related issue
Closes #39
Changes
Validation
npm run checknpm run check:generatednpm test— 60 passedAdditional validation: The cancellation tests failed before the fix because the callback was never called. The pending-cancellation test also fails if cleanup is awaited: it verifies that generation completes while cancellation remains pending, without a wall-clock timeout.
npm run test:releasepassed all 4 tests, andnpm run test:packageverified the installable package. Local validation used Node.js 25.9.0.Risk and compatibility
Checklist
Signed-off-byline.