Repository navigation
chore(release): 🔖 Sync package version and release commits - #11
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d63be2b33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| echo "already_released=false" >> "$GITHUB_OUTPUT" | ||
|
|
||
| if git log --format=%s --grep="$release_marker" -n 1 HEAD | grep -q "$release_marker"; then |
There was a problem hiding this comment.
Recheck the tag before declaring the release done
If a release run partially succeeds by pushing the release commit to the base branch but then fails while pushing v${NEXT_VERSION}, any rerun for that merged PR will hit this subject grep, set already_released=true, and exit before the later tag creation/push logic runs. That leaves the npm release without the matching Git tag and makes the workflow unable to repair it on rerun; the early-exit check should also verify the tag exists remotely or allow the tag step to run.
Useful? React with 👍 / 👎.
Summary
package.jsonto the already published npm version2.7.0.package.json, publish with Trusted Publishing, then commit the release version and create the matchingvX.Y.Ztag.Validation
git diff --checkyarn lint && yarn test:coverage && yarn build.github/workflows/ci.ymlwithjs-yaml