Repository navigation
fix(value-objects)!: 💥 Enforce strict validation and immutability - #29
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
haskou
changed the title
haskou
marked this pull request as ready for review
July 10, 2026 13:21
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1be53d804a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimestampInterval.modifyStart()andmodifyEnd()so interval boundaries remain immutable.Durationday and hour component calculations.Breaking changes
TimestampInterval.modifyStart()andmodifyEnd()are no longer available.NumberValueObject,Integer, andTimestamprejectInfinity,-Infinity, and invalid date values.UUIDrejects 36-character strings that do not match the standard UUID structure.CalendarDayrejects normalized dates such as2022-02-31.Root cause
Several validators delegated to permissive JavaScript behavior.
Datenormalized nonexistent dates, numeric validation rejected onlyNaN, and the UUID pattern checked character count without checking field structure.Duration.getHours()used seconds per hour as its modulo, and mutable timestamp intervals left the inherited primitive value out of sync with their boundaries.Validation
yarn test(808 tests)yarn test:coverage(100% statements, branches, functions, and lines)yarn buildyarn docs:build