-
Notifications
You must be signed in to change notification settings - Fork 1
Adding solr cloud service to babel #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8d254d0
3e4fdbd
868ba27
2820bcf
d293c9c
6d31165
77eba67
2699973
014ebfc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| num_shards_list = 1 | ||
| mbooks_solr_engines = http://solr-lss-dev:8983/solr/core-x | ||
| A_mbooks_solr_engines = http://solr-lss-dev:8983/solr/core-x | ||
| B_mbooks_solr_engines = http://solr-lss-dev:8983/solr/core-y | ||
| mbooks_solr_engines = ENV[LSS_SOLR_ENGINE_URL_A] | ||
| A_mbooks_solr_engines = ENV[LSS_SOLR_ENGINE_URL_A] | ||
| B_mbooks_solr_engines = ENV[LSS_SOLR_ENGINE_URL_B] | ||
| solr_basic_auth_token = ENV[LSS_SOLR_BASIC_AUTH] | ||
| # debug_enabled = 1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ sub __Solr_result { | |
| my ($C, $query_string, $rs, $AB) = @_; | ||
|
|
||
| my $url = $self->__get_Solr_select_url($C, $query_string, $AB); | ||
| my $req = $self->__get_request_object($url); | ||
| my $req = $self->__get_request_object($url, $C); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So the mdp-config with Solr auth token can be retrieved. |
||
| my $ua = $self->__create_user_agent(); | ||
|
|
||
| if (DEBUG('query')) { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -329,7 +329,7 @@ sub get_idp_list { | |
| $seen{$$hash_ref{inst_id}} = 1; | ||
|
|
||
| my $host = $ENV{'HTTP_HOST'} || 'localhost'; | ||
| my $idp_url = $hash_ref->{template}; | ||
| my $idp_url = $hash_ref->{template} // ''; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will help declutter the logs, because I am certain this is one of the sites of "uninitialized value" warnings cited in ETT-1776. This is the proper mitigation.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @moseshll I thought we had determined a long time ago that template wasn't actually being used, and so we haven't been keeping it up to date or even populated at all for some institutions. Is this code running but the result is never used anywhere? |
||
| $idp_url =~ s,___HOST___,$host,; | ||
| $idp_url =~ s,&,&,; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth a comment that this is the default 'admin:solrRocks' credential