ETT-1843: remove old css/js scripts - #251
Merged
Merged
Conversation
Member
Author
|
The perl test is failing though: |
Member
|
@liseli Could you see why this ls test is failing here? |
Member
|
Never mind, I think I saw the issue - the test was checking that we had js_css_filelist.txt in both the solr6 and solr 9 config, even though we don't need it and it was removed. |
aelkiss
approved these changes
Sep 8, 2026
aelkiss
left a comment
aelkiss
left a comment
Member
There was a problem hiding this comment.
Assuming tests pass this should be good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the functions (subroutines?) in
make_commonandmake_concatare only ever called by each other. The txt files look like older versions of some kind of manifest for ls/mb/pt assets. I'm sure all of this used to work together to build file names/paths for common assets, but that's not how builds are handled anymore, so these are safe to go.Staged on dev-3 for testing, and everything looks fine!