馃捇 Add aria-label for copy_to_editor button - #6650
Open
sstorck wants to merge 1 commit into
Open
Conversation
There are 2 places where the button is initialized. This adds it in both places as well as the new translation key. Lighthouse analysis ====== Before: https://googlechrome.github.io/lighthouse/viewer/?gist=8368d4b3d9215a987964c2a35f1d9c17 After: https://googlechrome.github.io/lighthouse/viewer/?gist=75e99825a571e518ed4defbbc3352e0e ISSUE=hedyorg#6647
github-project-automation
Bot
added this to
Newsletter content and Hedy organization board
sstorck
changed the title
Author
|
The Adding new translation keys section on the wiki doesn't include how to add them for typescript files, so I figured this might be a good example PR if this is the right way to handle it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 places where the button is initialized. This adds it in both places as well as the new translation key.
Issue: #6647
How to test
Inspect the copy button in DevTools.
Lighthouse analysis:
Checklist
Done? Check if you have it all in place using this list: (mark with x if done)
If you're unsure about any of these, don't hesitate to ask. We're here to help!